Misc fixes towards opentelemetry-sdk being type checked#5105
Merged
xrmx merged 11 commits intoopen-telemetry:mainfrom Apr 21, 2026
Merged
Misc fixes towards opentelemetry-sdk being type checked#5105xrmx merged 11 commits intoopen-telemetry:mainfrom
xrmx merged 11 commits intoopen-telemetry:mainfrom
Conversation
These variables are check for None at runtime so we can assume that later they are not Optional anymore.
Honestly no idea what's going on here.
MikeGoldsmith
approved these changes
Apr 21, 2026
Member
MikeGoldsmith
left a comment
MikeGoldsmith
left a comment
There was a problem hiding this comment.
Looks good, thanks @xrmx.
emdneto
approved these changes
Apr 21, 2026
…nential_histogram/mapping/__init__.py Co-authored-by: Mike Goldsmith <goldsmith.mike@gmail.com>
github-project-automation
bot
moved this from Ready for review
to Done
in Python PR digest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This drops two files but fixes a bunch of other issues as well.
Refs #1608
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Checklist: